Added redraw re-export from the highlightRenderer
#104
+5
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/text-annotator/src/TextAnnotator.ts
|
Hello, @rsimon 👋🏻 const handleScroll = () => {
r.state.store.recalculatePositions();
r.redraw(true);
};
Would it be possible to make this change a merge candidate? |
|
cc @rsimon, this change seems like another merge candidate for the next release 🙏🏻 |
rsimon
reviewed
Oct 13, 2025
| setSelected, | ||
| setPresenceProvider, | ||
| setVisible, | ||
| setVisible: highlightRenderer.setVisible.bind(highlightRenderer), |
There was a problem hiding this comment.
Is the binding actually necessary, given that the highlightRenderer is a function (and doesn't use this)?
There was a problem hiding this comment.
I believe it's an easy way to prevent setting a footgun. As one day we might wanna access this, and it would be great to have it properly populated.
I've just been bitten by a missing context issue too many times 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #103
Changes Made
redrawmethod to theTextAnnotatordefinitionhighlightRenderermethods(Soomo Staged, 09.09.25)